Issue 10084014: Measure code generation time as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10084014: Measure code generation time as well. (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Measure code generation time as well. Committed: https://code.google.com/p/dart/source/detail?r=6534

Patch Set 2 : #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
M	runtime/vm/compiler.cc	View		1 chunk	+2 lines, -0 lines	2 comments	Download
M	runtime/vm/compiler_stats.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/compiler_stats.cc	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

lgtm but see comment https://chromiumcodereview.appspot.com/10084014/diff/3002/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://chromiumcodereview.appspot.com/10084014/diff/3002/runtime/vm/compiler.cc#newcode131 runtime/vm/compiler.cc:131: TimerScope timer(FLAG_compiler_stats, &CompilerStats::codegen_timer); I don't ...

8 years, 8 months ago (2012-04-13 17:36:01 UTC) #2

srdjan

8 years, 8 months ago (2012-04-13 17:38:59 UTC) #3

https://chromiumcodereview.appspot.com/10084014/diff/3002/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://chromiumcodereview.appspot.com/10084014/diff/3002/runtime/vm/compiler...
runtime/vm/compiler.cc:131: TimerScope timer(FLAG_compiler_stats,
&CompilerStats::codegen_timer);
On 2012/04/13 17:36:02, hausner wrote:
> I don't know when exactly the constructor of variable timer gets called. If it
> can get called at the beginning of this scope, it would include parsing time
as
> well.

Per C++ spec it cannot be called before the instructions preceding it.

Expand Messages | Collapse Messages

Issue 10084014: Measure code generation time as well. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages