Issue 10083046: Fix issue 2621:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10083046: Fix issue 2621: (Closed)

Created:
8 years, 8 months ago by Ivan Posva

Modified:
8 years, 8 months ago

Reviewers:
srdjan, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Bill Hesse

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Fix issue 2621: - Properly restore long_jump_base when returning early. Committed: https://code.google.com/p/dart/source/detail?r=6693

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	vm/compiler.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

We should consider making LongJump a scope to avoid issues like these, but I remember ...

8 years, 8 months ago (2012-04-18 15:07:15 UTC) #1

srdjan

https://chromiumcodereview.appspot.com/10083046/diff/1/vm/compiler.cc File vm/compiler.cc (right): https://chromiumcodereview.appspot.com/10083046/diff/1/vm/compiler.cc#newcode140 vm/compiler.cc:140: isolate->set_long_jump_base(base); Thanks for fixing this, and sorry about introducing ...

8 years, 8 months ago (2012-04-18 15:43:47 UTC) #2

siva

8 years, 8 months ago (2012-04-18 18:59:33 UTC) #3

LGTM

I agree with Srdjan that the whole Longjump stuff could be moved after the check
for unoptimized code.

Expand Messages | Collapse Messages