Issue 10083007: Resolve implicit super calls.

Issue 10083007: Resolve implicit super calls. (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Resolve implicit super calls. Committed: https://code.google.com/p/dart/source/detail?r=6574

Patch Set 2 : Improve comment. #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -73 lines)			Patch
M	lib/compiler/implementation/resolver.dart	View	1	9 chunks	+104 lines, -72 lines	0 comments	Download
M	lib/compiler/implementation/warnings.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
A	tests/language/src/SuperCall3Test.dart	View	1	1 chunk	+43 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

https://chromiumcodereview.appspot.com/10083007/diff/1/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://chromiumcodereview.appspot.com/10083007/diff/1/lib/compiler/implementation/resolver.dart#newcode80 lib/compiler/implementation/resolver.dart:80: final ClassElement classElement = constructor.enclosingElement; I inlined the code ...

8 years, 8 months ago (2012-04-13 18:08:47 UTC) #1

karlklose

LGTM. http://codereview.chromium.org/10083007/diff/1/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): http://codereview.chromium.org/10083007/diff/1/lib/compiler/implementation/resolver.dart#newcode80 lib/compiler/implementation/resolver.dart:80: final ClassElement classElement = constructor.enclosingElement; I am fine ...

8 years, 8 months ago (2012-04-16 13:01:51 UTC) #2

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10083007/diff/3001/tests/language/src/SuperCall3Test.dart File tests/language/src/SuperCall3Test.dart (right): https://chromiumcodereview.appspot.com/10083007/diff/3001/tests/language/src/SuperCall3Test.dart#newcode9 tests/language/src/SuperCall3Test.dart:9: this.x; /// 01: compile-time error the ';' will ...

8 years, 8 months ago (2012-04-16 16:04:04 UTC) #3

floitsch

8 years, 8 months ago (2012-04-16 16:18:43 UTC) #4

https://chromiumcodereview.appspot.com/10083007/diff/3001/tests/language/src/...
File tests/language/src/SuperCall3Test.dart (right):

https://chromiumcodereview.appspot.com/10083007/diff/3001/tests/language/src/...
tests/language/src/SuperCall3Test.dart:9: this.x;  /// 01: compile-time error
On 2012/04/16 16:04:04, ngeoffray wrote:
> the ';' will indeed make it a compile-time error :)

nice catch.
fixed in https://chromiumcodereview.appspot.com/9972016.

Expand Messages | Collapse Messages