Issue 10082017: Remove code index table.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10082017: Remove code index table. (Closed)

Created:
8 years, 8 months ago by siva

Modified:
8 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Remove code index table. Committed: https://code.google.com/p/dart/source/detail?r=6557

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -604 lines)			Patch
D	vm/code_index_table.h	View	1 chunk	+0 lines, -168 lines	0 comments	Download
D	vm/code_index_table.cc	View	1 chunk	+0 lines, -257 lines	0 comments	Download
D	vm/code_index_table_test.cc	View	1 chunk	+0 lines, -156 lines	0 comments	Download
M	vm/dart.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	vm/disassembler_ia32.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
A +	vm/find_code_object_test.cc	View	3 chunks	+3 lines, -3 lines	1 comment	Download
M	vm/isolate.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	vm/isolate.cc	View	4 chunks	+0 lines, -8 lines	0 comments	Download
M	vm/vm_sources.gypi	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

srdjan

8 years, 8 months ago (2012-04-13 20:47:01 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10082017/diff/1/vm/find_code_object_te...
File vm/find_code_object_test.cc (right):

https://chromiumcodereview.appspot.com/10082017/diff/1/vm/find_code_object_te...
vm/find_code_object_test.cc:27: String& url =
String::Handle(String::New("dart-test:FincCodeObject"));
Finc -> Find

Expand Messages | Collapse Messages