Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 10081039: Add some tests. (Closed)

Created:
8 years, 8 months ago by floitsch
Modified:
8 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add some failing (in Dart2Js) tests. Committed: https://code.google.com/p/dart/source/detail?r=6566

Patch Set 1 #

Patch Set 2 : Make test more difficult to pass. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language-leg.status View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/src/ListDoubleIndexInLoopTest.dart View 1 1 chunk +25 lines, -0 lines 2 comments Download
A tests/language/src/Operator4Test.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
8 years, 8 months ago (2012-04-14 19:55:43 UTC) #1
floitsch
Updated test. A small change in the compiler could infer that int + double always ...
8 years, 8 months ago (2012-04-14 20:02:01 UTC) #2
Lasse Reichstein Nielsen
LGTM http://codereview.chromium.org/10081039/diff/1005/tests/language/src/ListDoubleIndexInLoopTest.dart File tests/language/src/ListDoubleIndexInLoopTest.dart (right): http://codereview.chromium.org/10081039/diff/1005/tests/language/src/ListDoubleIndexInLoopTest.dart#newcode10 tests/language/src/ListDoubleIndexInLoopTest.dart:10: // combined with 'integer' (i = 0) was ...
8 years, 8 months ago (2012-04-16 10:43:32 UTC) #3
floitsch
8 years, 8 months ago (2012-04-16 12:08:37 UTC) #4
http://codereview.chromium.org/10081039/diff/1005/tests/language/src/ListDoub...
File tests/language/src/ListDoubleIndexInLoopTest.dart (right):

http://codereview.chromium.org/10081039/diff/1005/tests/language/src/ListDoub...
tests/language/src/ListDoubleIndexInLoopTest.dart:10: // combined with 'integer'
(i = 0) was narrowed to 'integer'. As a result no
On 2012/04/16 10:43:32, Lasse Reichstein Nielsen wrote:
> What kind of type propagation is this? For optimization only?
> Narrowing num to int seems like an unsafe analysis.

Narrowing has uses too. In this case, of course, it's a bug. I will fix it.

Powered by Google App Engine
This is Rietveld 408576698