Do not delete DOMStringMap and DOMStringList types from idl database.

Do not delete DOMStringMap and DOMStringList types from idl database.

R=antonm@chromium.org,sra@chromium.org

Committed: https://code.google.com/p/dart/source/detail?r=6623

[Anton Muhin, 2012-04-13 16:46:34]

https://chromiumcodereview.appspot.com/10080008/diff/1/lib/dom/src/native_DOM...
File lib/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/10080008/diff/1/lib/dom/src/native_DOM...
lib/dom/src/native_DOMImplementation.dart:82: class DOMStringMapImplementation
extends DOMWrapperBase implements DOMStringMap {
don't you have to add DOMStringListImplementation at least here?

[podivilov, 2012-04-13 16:49:26]

https://chromiumcodereview.appspot.com/10080008/diff/1/lib/dom/src/native_DOM...
File lib/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/10080008/diff/1/lib/dom/src/native_DOM...
lib/dom/src/native_DOMImplementation.dart:82: class DOMStringMapImplementation
extends DOMWrapperBase implements DOMStringMap {
On 2012/04/13 16:46:34, antonmuhin wrote:
> don't you have to add DOMStringListImplementation at least here?

Could you please clarify? We need to add DOMStringListImplementation class at
some point, but this change is pure refactoring.

[Anton Muhin, 2012-04-13 16:51:18]

https://chromiumcodereview.appspot.com/10080008/diff/1/lib/dom/src/native_DOM...
File lib/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/10080008/diff/1/lib/dom/src/native_DOM...
lib/dom/src/native_DOMImplementation.dart:82: class DOMStringMapImplementation
extends DOMWrapperBase implements DOMStringMap {
I don't think it's a good idea to stop removing DOMStringList, but not prove
implementation class for it.  Esp. given the fact that to add
DOMStringListInplmpl will take rougly 10--15 lines of code.

On 2012/04/13 16:49:26, podivilov wrote:
> On 2012/04/13 16:46:34, antonmuhin wrote:
> > don't you have to add DOMStringListImplementation at least here?
> 
> Could you please clarify? We need to add DOMStringListImplementation class at
> some point, but this change is pure refactoring.

[podivilov, 2012-04-13 17:00:53]

https://chromiumcodereview.appspot.com/10080008/diff/1/lib/dom/src/native_DOM...
File lib/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/10080008/diff/1/lib/dom/src/native_DOM...
lib/dom/src/native_DOMImplementation.dart:82: class DOMStringMapImplementation
extends DOMWrapperBase implements DOMStringMap {
On 2012/04/13 16:51:18, antonmuhin wrote:
> I don't think it's a good idea to stop removing DOMStringList, but not prove
> implementation class for it.  Esp. given the fact that to add
> DOMStringListInplmpl will take rougly 10--15 lines of code.
> 
> On 2012/04/13 16:49:26, podivilov wrote:
> > On 2012/04/13 16:46:34, antonmuhin wrote:
> > > don't you have to add DOMStringListImplementation at least here?
> > 
> > Could you please clarify? We need to add DOMStringListImplementation class
at
> > some point, but this change is pure refactoring.
> 

The problem with it is that we'll have to provide a c++ implementation as well,
which is many more lines and better done as a separate cl.

If you think unused DOMStringList interface that appeared as a side-effect of
this change is a problem, I could leave DOMStringList part as is for now.

[Anton Muhin, 2012-04-13 17:08:56]

https://chromiumcodereview.appspot.com/10080008/diff/1/lib/dom/src/native_DOM...
File lib/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/10080008/diff/1/lib/dom/src/native_DOM...
lib/dom/src/native_DOMImplementation.dart:82: class DOMStringMapImplementation
extends DOMWrapperBase implements DOMStringMap {
Whatever you prefer.

On 2012/04/13 17:00:53, podivilov wrote:
> On 2012/04/13 16:51:18, antonmuhin wrote:
> > I don't think it's a good idea to stop removing DOMStringList, but not prove
> > implementation class for it.  Esp. given the fact that to add
> > DOMStringListInplmpl will take rougly 10--15 lines of code.
> > 
> > On 2012/04/13 16:49:26, podivilov wrote:
> > > On 2012/04/13 16:46:34, antonmuhin wrote:
> > > > don't you have to add DOMStringListImplementation at least here?
> > > 
> > > Could you please clarify? We need to add DOMStringListImplementation class
> at
> > > some point, but this change is pure refactoring.
> > 
> 
> The problem with it is that we'll have to provide a c++ implementation as
well,
> which is many more lines and better done as a separate cl.
> 
> If you think unused DOMStringList interface that appeared as a side-effect of
> this change is a problem, I could leave DOMStringList part as is for now.

[Anton Muhin, 2012-04-16 16:20:11]

LGTM