Issue 10080005: Support Expectation.identical.

Issue 10080005: Support Expectation.identical. (Closed)

Created:
8 years, 8 months ago by Anton Muhin

Modified:
8 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org, podivilov

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support Expectation.identical. Committed: https://code.google.com/p/dart/source/detail?r=6533

Patch Set 2 : Addressing Bob's comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	client/tests/client/dom/MessageEventTest.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
	M	lib/unittest/expectation.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

I'd suggest a name change, but either way LGTM! https://chromiumcodereview.appspot.com/10080005/diff/1/lib/unittest/expectation.dart File lib/unittest/expectation.dart (right): https://chromiumcodereview.appspot.com/10080005/diff/1/lib/unittest/expectation.dart#newcode44 lib/unittest/expectation.dart:44: ...

8 years, 8 months ago (2012-04-13 15:59:46 UTC) #2

Anton Muhin

https://chromiumcodereview.appspot.com/10080005/diff/1/lib/unittest/expectation.dart File lib/unittest/expectation.dart (right): https://chromiumcodereview.appspot.com/10080005/diff/1/lib/unittest/expectation.dart#newcode44 lib/unittest/expectation.dart:44: void identical(expected) { On 2012/04/13 15:59:46, Bob Nystrom wrote: ...

8 years, 8 months ago (2012-04-13 16:04:14 UTC) #3

Bob Nystrom

On 2012/04/13 16:04:14, antonmuhin wrote: > https://chromiumcodereview.appspot.com/10080005/diff/1/lib/unittest/expectation.dart > File lib/unittest/expectation.dart (right): > > https://chromiumcodereview.appspot.com/10080005/diff/1/lib/unittest/expectation.dart#newcode44 > ...

8 years, 8 months ago (2012-04-13 16:51:39 UTC) #4

Anton Muhin

8 years, 8 months ago (2012-04-13 16:54:27 UTC) #5

https://chromiumcodereview.appspot.com/10080005/diff/1/lib/unittest/expectati...
File lib/unittest/expectation.dart (right):

https://chromiumcodereview.appspot.com/10080005/diff/1/lib/unittest/expectati...
lib/unittest/expectation.dart:44: void identical(expected) {
Done.  Thanks a lot, landing.

On 2012/04/13 16:04:14, antonmuhin wrote:
> On 2012/04/13 15:59:46, Bob Nystrom wrote:
> > How about "same" or "sameAs"?
> 
> I'd vote for same, is it ok w/ you?

Expand Messages | Collapse Messages