Issue 10079028: Next IndexedDB test - scan with a cursor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10079028: Next IndexedDB test - scan with a cursor. (Closed)

Created:
8 years, 8 months ago by sra1

Modified:
8 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Next IndexedDB test - scan with a cursor. Committed: https://code.google.com/p/dart/source/detail?r=6609

Patch Set 1 : #

Total comments: 2

Patch Set 2 : merge #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -2 lines)			Patch
M	client/tests/client/client.status	View		3 chunks	+7 lines, -2 lines	0 comments	Download
M	client/tests/client/client-leg.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	client/tests/client/dom/IndexedDB3Test.dart	View	1	1 chunk	+119 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 8 months ago (2012-04-16 19:41:39 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10079028/diff/3004/client/tests/client...
File client/tests/client/dom/IndexedDB3Test.dart (right):

https://chromiumcodereview.appspot.com/10079028/diff/3004/client/tests/client...
client/tests/client/dom/IndexedDB3Test.dart:1: #library('IndexedDB1Test');
DB1->DB3 in lib name

https://chromiumcodereview.appspot.com/10079028/diff/3004/client/tests/client...
client/tests/client/dom/IndexedDB3Test.dart:33: print('Deleted store
$STORE_NAME');
Extraneous prints sometimes screw up our tests.

Expand Messages | Collapse Messages