Issue 10079018: Introduce an equality compare node. Equality will need to be handled specially soon (not just an in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10079018: Introduce an equality compare node. Equality will need to be handled specially soon (not just an in… (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Introduce an equality compare node. Equality will need to be handled specially soon (not just an instance call) and today it needs special code for efficeintly handling null receivers (null-class is never entered into IC data). This fixes a significant performance regression between the old and the new compiler. Committed: https://code.google.com/p/dart/source/detail?r=6544

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -22 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	4 chunks	+34 lines, -21 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	2 chunks	+39 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages