Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 10079008: Add SerializedScriptValueTest. (Closed)

Created:
8 years, 8 months ago by Anton Muhin
Modified:
8 years, 8 months ago
Reviewers:
podivilov, sra
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add SerializedScriptValueTest. Committed: https://code.google.com/p/dart/source/detail?r=6530

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressing commetns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -61 lines) Patch
M client/tests/client/dom/IndexedDB2Test.dart View 2 chunks +1 line, -61 lines 0 comments Download
A client/tests/client/dom/SerializedScriptValueTest.dart View 1 1 chunk +38 lines, -0 lines 0 comments Download
A client/tests/client/dom/utils.dart View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Anton Muhin
8 years, 8 months ago (2012-04-13 16:07:28 UTC) #1
podivilov
https://chromiumcodereview.appspot.com/10079008/diff/1/client/tests/client/dom/SerializedScriptValueTest.dart File client/tests/client/dom/SerializedScriptValueTest.dart (right): https://chromiumcodereview.appspot.com/10079008/diff/1/client/tests/client/dom/SerializedScriptValueTest.dart#newcode32 client/tests/client/dom/SerializedScriptValueTest.dart:32: final cyclicList = [ dagList ]; cyclicList.add(cyclicList); nit: missing ...
8 years, 8 months ago (2012-04-13 16:23:23 UTC) #2
Anton Muhin
https://chromiumcodereview.appspot.com/10079008/diff/1/client/tests/client/dom/SerializedScriptValueTest.dart File client/tests/client/dom/SerializedScriptValueTest.dart (right): https://chromiumcodereview.appspot.com/10079008/diff/1/client/tests/client/dom/SerializedScriptValueTest.dart#newcode32 client/tests/client/dom/SerializedScriptValueTest.dart:32: final cyclicList = [ dagList ]; cyclicList.add(cyclicList); On 2012/04/13 ...
8 years, 8 months ago (2012-04-13 16:25:52 UTC) #3
podivilov
http://codereview.chromium.org/10079008/diff/1/client/tests/client/dom/SerializedScriptValueTest.dart File client/tests/client/dom/SerializedScriptValueTest.dart (right): http://codereview.chromium.org/10079008/diff/1/client/tests/client/dom/SerializedScriptValueTest.dart#newcode32 client/tests/client/dom/SerializedScriptValueTest.dart:32: final cyclicList = [ dagList ]; cyclicList.add(cyclicList); On 2012/04/13 ...
8 years, 8 months ago (2012-04-13 16:26:54 UTC) #4
Anton Muhin
http://codereview.chromium.org/10079008/diff/1/client/tests/client/dom/SerializedScriptValueTest.dart File client/tests/client/dom/SerializedScriptValueTest.dart (right): http://codereview.chromium.org/10079008/diff/1/client/tests/client/dom/SerializedScriptValueTest.dart#newcode32 client/tests/client/dom/SerializedScriptValueTest.dart:32: final cyclicList = [ dagList ]; cyclicList.add(cyclicList); On 2012/04/13 ...
8 years, 8 months ago (2012-04-13 16:28:04 UTC) #5
podivilov
8 years, 8 months ago (2012-04-13 16:30:24 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698