Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 10078011: Fix flaky standalone/io/TestRunnerTest, a unit test of the testing framework. (Closed)

Created:
8 years, 8 months ago by Bill Hesse
Modified:
8 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix flaky standalone/io/TestRunnerTest, a unit test of the testing framework. BUG=dart:1947 TEST=standalone/io/TestRunnerTest Committed: https://code.google.com/p/dart/source/detail?r=6734

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use test_options.dart to make the configurations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M tests/standalone/src/io/TestRunnerTest.dart View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
8 years, 8 months ago (2012-04-19 10:11:33 UTC) #1
Mads Ager (google)
LGTM, but see comment for a follow-up change that I think would be worth it. ...
8 years, 8 months ago (2012-04-19 10:15:11 UTC) #2
Bill Hesse
Switched to using test_options.dart to generate the configurations.
8 years, 8 months ago (2012-04-19 10:26:56 UTC) #3
Mads Ager (google)
8 years, 8 months ago (2012-04-19 10:38:29 UTC) #4
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698