Issue 10073013: Drop DatabaseBuilder.set_same_signatures method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10073013: Drop DatabaseBuilder.set_same_signatures method. (Closed)

Created:
8 years, 8 months ago by podivilov

Modified:
8 years, 8 months ago

Reviewers:
antonm, Anton Muhin, sra

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Drop DatabaseBuilder.set_same_signatures method. It doesn't affect code generation at all. R=sra@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6677

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -14 lines)			Patch
M	lib/dom/idl/dart/dart.idl	View	1 chunk	+1 line, -1 line	2 comments	Download
M	lib/dom/scripts/databasebuilder.py	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	lib/dom/scripts/fremontcutbuilder.py	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

Another nice cleanup, LGTM http://codereview.chromium.org/10073013/diff/1/lib/dom/idl/dart/dart.idl File lib/dom/idl/dart/dart.idl (right): http://codereview.chromium.org/10073013/diff/1/lib/dom/idl/dart/dart.idl#newcode196 lib/dom/idl/dart/dart.idl:196: [Suppressed] const long BYTES_PER_ELEMENT = ...

8 years, 8 months ago (2012-04-17 10:59:04 UTC) #2

podivilov

8 years, 8 months ago (2012-04-18 10:37:01 UTC) #3

http://codereview.chromium.org/10073013/diff/1/lib/dom/idl/dart/dart.idl
File lib/dom/idl/dart/dart.idl (right):

http://codereview.chromium.org/10073013/diff/1/lib/dom/idl/dart/dart.idl#newc...
lib/dom/idl/dart/dart.idl:196: [Suppressed] const long BYTES_PER_ELEMENT = 1;
On 2012/04/17 10:59:04, antonmuhin wrote:
> does this bring us closer to upstream?

Not really, but now the type of this suppressed constant matches WebKit idl.

Expand Messages | Collapse Messages