Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 10073001: Fix HTTP links in URI docs. (Closed)

Created:
8 years, 8 months ago by Bob Nystrom
Modified:
8 years, 8 months ago
Reviewers:
Kathy Walrath, ahe, sethladd
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Fix HTTP links in URI docs. Also fixes a bug in our markdown parser where reference links are not correctly case-insensitive. Committed: https://code.google.com/p/dart/source/detail?r=6606

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M lib/dartdoc/inline_parser.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/dartdoc/markdown.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M lib/uri/uri.dart View 2 chunks +4 lines, -5 lines 4 comments Download
M tests/utils/src/MarkdownTest.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
Fixes Bug #2541.
8 years, 8 months ago (2012-04-12 17:48:14 UTC) #1
ahe
https://chromiumcodereview.appspot.com/10073001/diff/1/lib/uri/uri.dart File lib/uri/uri.dart (right): https://chromiumcodereview.appspot.com/10073001/diff/1/lib/uri/uri.dart#newcode9 lib/uri/uri.dart:9: * [uri]: http://closure-library.googlecode.com/svn/docs/class_goog_Uri.html I don't think this follows the ...
8 years, 8 months ago (2012-04-12 18:24:22 UTC) #2
sethladd
lgtm
8 years, 8 months ago (2012-04-16 22:01:37 UTC) #3
Bob Nystrom
8 years, 8 months ago (2012-04-16 22:04:23 UTC) #4
Thanks!

http://codereview.chromium.org/10073001/diff/1/lib/uri/uri.dart
File lib/uri/uri.dart (right):

http://codereview.chromium.org/10073001/diff/1/lib/uri/uri.dart#newcode9
lib/uri/uri.dart:9: * [uri]:
http://closure-library.googlecode.com/svn/docs/class_goog_Uri.html
On 2012/04/12 18:24:22, ahe wrote:
> I don't think this follows the conventions we follow in the rest of the
> libraries:
> 
>
http://chromegw.corp.google.com/viewvc/dash/attic/guide/dartguide.xml#Comment...
> (sorry, this is an internal Google link, we should get this published).

I didn't even remember that the old guide specified a way to include hyperlinks.
:(

Dartdoc doesn't support that (because I forgot about it). It does support the
three flavors of hyperlinks markdown supports of which this is one. I only found
a few places in our codebase where we have the old style comments (assuming my
grep-foo is strong enough). If you'd like, I can update those to use regular
markdown links too.

http://codereview.chromium.org/10073001/diff/1/lib/uri/uri.dart#newcode76
lib/uri/uri.dart:76: * Returns `true` if the URI is absolute.
On 2012/04/12 18:24:22, ahe wrote:
> [true] instead of `true`.

[true] is for links to identifiers, but "true" is just a reserved word.
Backticks will be parsed as inline <code>, which is I think what we want here.
If I remember, I believe that's the convention the MSDN docs use, for example.

Powered by Google App Engine
This is Rietveld 408576698