Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 10069053: Fix Process test, fix Process factory, diable tests on dart2js. (Closed)

Created:
8 years, 8 months ago by Mads Ager (google)
Modified:
8 years, 8 months ago
Reviewers:
Søren Gjesse, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix Process test, fix Process factory, diable tests on dart2js. Florian and I will investigate the dart2js failures. R=sgjesse@google.com,floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M runtime/bin/process_impl.dart View 3 chunks +12 lines, -14 lines 0 comments Download
M tests/standalone/src/io/ProcessRunOutputTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone-leg.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 8 months ago (2012-04-13 09:21:33 UTC) #1
Søren Gjesse
8 years, 8 months ago (2012-04-13 09:35:39 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698