Issue 10069042: Simplify code in code code generator, move checks to flow graph builder. We can assume that any typ…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10069042: Simplify code in code code generator, move checks to flow graph builder. We can assume that any typ… (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Simplify code in code code generator, move checks to flow graph builder. We can assume that any type analysis will occur before the code generator gets called. Committed: https://code.google.com/p/dart/source/detail?r=6532

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -41 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	1 chunk	+54 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages