Issue 10069039: Add infrastructure to create and run benchmarks specific to some VM functionality. This is used to …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10069039: Add infrastructure to create and run benchmarks specific to some VM functionality. This is used to … (Closed)

Created:
8 years, 8 months ago by siva

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add infrastructure to create and run benchmarks specific to some VM functionality. This is used to measure performance of specific VM functionality (similar to VM unit tests testing specific VM functionality) run_vm_tests --benchmarks to run all benchmarks or run_vm_tests CorelibCompileAll Committed: https://code.google.com/p/dart/source/detail?r=6820

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+222 lines, -19 lines)			Patch
M	bin/run_vm_tests.cc	View	1 2	5 chunks	+47 lines, -19 lines	0 comments	Download
A	vm/benchmark_test.h	View	1	1 chunk	+107 lines, -0 lines	0 comments	Download
A	vm/benchmark_test.cc	View	1 2	1 chunk	+66 lines, -0 lines	2 comments	Download
M	vm/vm_sources.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10069039/diff/10001/vm/benchmark_test.cc File vm/benchmark_test.cc (right): https://chromiumcodereview.appspot.com/10069039/diff/10001/vm/benchmark_test.cc#newcode41 vm/benchmark_test.cc:41: char* err; initialize to NULL?

8 years, 8 months ago (2012-04-20 23:13:55 UTC) #2

siva

8 years, 7 months ago (2012-04-30 16:38:04 UTC) #3

https://chromiumcodereview.appspot.com/10069039/diff/10001/vm/benchmark_test.cc
File vm/benchmark_test.cc (right):

https://chromiumcodereview.appspot.com/10069039/diff/10001/vm/benchmark_test....
vm/benchmark_test.cc:41: char* err;
On 2012/04/20 23:13:55, srdjan wrote:
> initialize to NULL?

Done.

Expand Messages | Collapse Messages