Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 10068008: Adds parser recovery at the statement level for unterminated statements (no semicolon) (Closed)

Created:
8 years, 8 months ago by zundel
Modified:
8 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, messick
Visibility:
Public.

Description

Adds parser recovery at the statement level for unterminated statements (no semicolon) this change will allow the parser to recover when it sees the start of a new statement after an invalid token. All 24 of these new test cases failed in the state the code right before this change, so I'm hoping this will make a significant improvement in the quality of the AST created and therefore code completion. Committed: https://code.google.com/p/dart/source/detail?r=6463

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+589 lines, -79 lines) Patch
M compiler/java/com/google/dart/compiler/parser/AbstractParser.java View 1 chunk +8 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 10 chunks +48 lines, -66 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/ParserRecoveryTest.java View 3 chunks +516 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/TruncatedSourceParserTest.java View 6 chunks +17 lines, -12 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
zundel
https://chromiumcodereview.appspot.com/10068008/diff/1/compiler/javatests/com/google/dart/compiler/parser/TruncatedSourceParserTest.java File compiler/javatests/com/google/dart/compiler/parser/TruncatedSourceParserTest.java (right): https://chromiumcodereview.appspot.com/10068008/diff/1/compiler/javatests/com/google/dart/compiler/parser/TruncatedSourceParserTest.java#newcode25 compiler/javatests/com/google/dart/compiler/parser/TruncatedSourceParserTest.java:25: private ParseState state = ParseState.INIT; There are no important ...
8 years, 8 months ago (2012-04-12 10:35:40 UTC) #1
scheglov
8 years, 8 months ago (2012-04-12 13:32:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698