prevent cached DartUnit from being referenced and resolved by multiple libraries

prevent cached DartUnit from being referenced and resolved by multiple libraries
Committed: https://code.google.com/p/dart/source/detail?r=6470

[zundel, 2012-04-12 19:00:34]

https://chromiumcodereview.appspot.com/10066020/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/10066020/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompiler.java:886: DartUnit
parsedUnit = parsedUnits.remove(srcUri);
couldn't you just not parse it a second time?  Or does this parsedUnits persist
between runs of the analyzer?

[danrubel, 2012-04-12 19:17:44]

https://chromiumcodereview.appspot.com/10066020/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/10066020/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompiler.java:886: DartUnit
parsedUnit = parsedUnits.remove(srcUri);
On 2012/04/12 19:00:34, zundel wrote:
> couldn't you just not parse it a second time?  Or does this parsedUnits
persist
> between runs of the analyzer?

If I analyze a library that imports two other libraries, each of which #source
the same file, and that file is in the parsedUnits cache, then that same
DartUnit ends up being referenced by two different libraries, and the resolver
breaks when it tries to resolve that DartUnit a 2nd time. This was the easiest
solution... remove the DartUnit from the cache once it is attached to a library.

[scheglov, 2012-04-12 19:21:40]

LGTM

[zundel, 2012-04-12 19:24:54]

lgtm