Issue 10065013: Support length operation without opening file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10065013: Support length operation without opening file. (Closed)

Created:
8 years, 8 months ago by Mads Ager (google)

Modified:
8 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support length operation without opening file. Use fstat instead of multiple seek calls to get length of opened files. R=sgjesse@google.com BUG=dartbug.com/1592 TEST=standalone/io/File*Test Committed: https://code.google.com/p/dart/source/detail?r=6459

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix error message and fix Windows port #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+190 lines, -61 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.h	View		2 chunks	+8 lines, -6 lines	0 comments	Download
M	runtime/bin/file.cc	View		3 chunks	+35 lines, -0 lines	0 comments	Download
M	runtime/bin/file.dart	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/bin/file_impl.dart	View	1	4 chunks	+41 lines, -6 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View		2 chunks	+13 lines, -7 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View		2 chunks	+13 lines, -7 lines	0 comments	Download
M	runtime/bin/file_win.cc	View	1	2 chunks	+13 lines, -7 lines	0 comments	Download
M	tests/standalone/src/io/FileErrorTest.dart	View	1	5 chunks	+41 lines, -21 lines	0 comments	Download
M	tests/standalone/src/io/FileTest.dart	View		1 chunk	+14 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/10065013/diff/1/runtime/bin/file_impl.dart File runtime/bin/file_impl.dart (right): https://chromiumcodereview.appspot.com/10065013/diff/1/runtime/bin/file_impl.dart#newcode540 runtime/bin/file_impl.dart:540: throw new FileIOException("Cannot retrieve lenght for file", result); ...

8 years, 8 months ago (2012-04-12 11:41:44 UTC) #2

Mads Ager (google)

8 years, 8 months ago (2012-04-13 12:24:11 UTC) #3

https://chromiumcodereview.appspot.com/10065013/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10065013/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:540: throw new FileIOException("Cannot retrieve
lenght for file", result);
On 2012/04/12 11:41:44, Søren Gjesse wrote:
> lenght -> length
> for -> of

Done.

Expand Messages | Collapse Messages