Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 10054031: Pass optional arguments to NullPointerException constructor. (Closed)

Created:
8 years, 8 months ago by sra1
Modified:
8 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Pass optional arguments to NullPointerException constructor. Committed: https://code.google.com/p/dart/source/detail?r=6468

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M corelib/src/exceptions.dart View 1 chunk +2 lines, -9 lines 0 comments Download
M frog/lib/natives.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M frog/minfrog View 2 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
This version uses List.toString which saves code size in JavaScript.
8 years, 8 months ago (2012-04-12 17:29:03 UTC) #1
srdjan
8 years, 8 months ago (2012-04-12 18:22:44 UTC) #2
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698