Issue 10054027: Fix for Issue 2367

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10054027: Fix for Issue 2367 (Closed)

Created:
8 years, 8 months ago by siva

Modified:
8 years, 8 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for Issue 2367 The '\r' character was included in the string literal when parsing integer or double literals. This was resulting in incorrect integer values being created. Committed: https://code.google.com/p/dart/source/detail?r=6442

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	runtime/vm/scanner.cc	View	1	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM w/comment https://chromiumcodereview.appspot.com/10054027/diff/1/runtime/vm/scanner.cc File runtime/vm/scanner.cc (right): https://chromiumcodereview.appspot.com/10054027/diff/1/runtime/vm/scanner.cc#newcode185 runtime/vm/scanner.cc:185: // Replace '\r' with '\n' and a ...

8 years, 8 months ago (2012-04-11 21:43:58 UTC) #2

siva

8 years, 8 months ago (2012-04-11 22:04:40 UTC) #3

https://chromiumcodereview.appspot.com/10054027/diff/1/runtime/vm/scanner.cc
File runtime/vm/scanner.cc (right):

https://chromiumcodereview.appspot.com/10054027/diff/1/runtime/vm/scanner.cc#...
runtime/vm/scanner.cc:185: // Replace '\r' with '\n' and a sequence of
On 2012/04/11 21:43:58, hausner wrote:
> This comment should probably be slightly adjusted, since the \r\n sequence is
> handled above now.

Done.

Expand Messages | Collapse Messages