Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 10052021: Fix "package:" stuff on Windows and skip tests on dart2js since it doesn't support it yet. (Closed)

Created:
8 years, 8 months ago by Bob Nystrom
Modified:
8 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix "package:" stuff on Windows and skip tests on dart2js since it doesn't support it yet. Committed: https://code.google.com/p/dart/source/detail?r=6431

Patch Set 1 #

Patch Set 2 : Tpyo. #

Patch Set 3 : Typo. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M runtime/bin/builtin.dart View 2 chunks +26 lines, -8 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
Checking in TBR to see if it makes the buildbots happy.
8 years, 8 months ago (2012-04-11 20:13:33 UTC) #1
srdjan
LGTM
8 years, 8 months ago (2012-04-11 20:16:03 UTC) #2
srdjan
On 2012/04/11 20:16:03, srdjan wrote: > LGTM revoking LGTM :-)
8 years, 8 months ago (2012-04-11 20:17:14 UTC) #3
ahe
DBC https://chromiumcodereview.appspot.com/10052021/diff/3001/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://chromiumcodereview.appspot.com/10052021/diff/3001/tests/standalone/standalone.status#newcode41 tests/standalone/standalone.status:41: package/PackageTest: Skip # TODO(rnystrom): Re-enable these once dart2js ...
8 years, 8 months ago (2012-04-12 18:16:25 UTC) #4
Bob Nystrom
8 years, 8 months ago (2012-04-12 21:18:26 UTC) #5
https://chromiumcodereview.appspot.com/10052021/diff/3001/tests/standalone/st...
File tests/standalone/standalone.status (right):

https://chromiumcodereview.appspot.com/10052021/diff/3001/tests/standalone/st...
tests/standalone/standalone.status:41: package/PackageTest: Skip    #
TODO(rnystrom): Re-enable these once dart2js
On 2012/04/12 18:16:26, ahe wrote:
> It would be great if you could use "Fail" instead of "Skip".

Good call. I didn't really think that through.

> Also, we actually have a separate status file for dart2js to avoid polluting
the status files with
> all our bugs :-)
> This file is called standalone-leg.status. It's in the same directory.

Oh, thanks. Actually I may be able to delete this entirely. Now that package: is
working in dart2js too, this test may work. I'll try it out and see.

Powered by Google App Engine
This is Rietveld 408576698