Issue 10052011: Fix flaky message queue test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10052011: Fix flaky message queue test. (Closed)

Created:
8 years, 8 months ago by Mads Ager (google)

Modified:
8 years, 8 months ago

Reviewers:
turnidge, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix flaky message queue test. The test assumes that MessageQueue::Dequeue(0) cannot return NULL. However, MessageQueue::Dequeue(0) returns NULL in case of spurious wakeup. R=turnidge@google.com,sgjesse@google.com BUG=dartbug.com/2004 TEST= Committed: https://code.google.com/p/dart/source/detail?r=6453

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -12 lines)			Patch
	M	runtime/vm/message_test.cc	View	1	1 chunk	+21 lines, -12 lines	0 comments	Download

Total messages: 2 (0 generated)

turnidge

8 years, 8 months ago (2012-04-11 18:32:41 UTC) #2

lgtm

Thanks for fixing this.  Ironically, I'm going to be deleting this test very
soon....