Issue 10051011: Eliminate type checks that can successfully be performed at compile time.

Issue 10051011: Eliminate type checks that can successfully be performed at compile time. (Closed)

Created:
8 years, 8 months ago by regis

Modified:
8 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Eliminate type checks that can successfully be performed at compile time. Committed: https://code.google.com/p/dart/source/detail?r=6420

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -45 lines)			Patch
M	runtime/vm/code_generator_ia32.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	16 chunks	+64 lines, -7 lines	0 comments	Download
M	runtime/vm/code_generator_x64.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1	16 chunks	+67 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	5 chunks	+36 lines, -2 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	2 chunks	+8 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

https://chromiumcodereview.appspot.com/10051011/diff/1/runtime/vm/code_generator_ia32.cc File runtime/vm/code_generator_ia32.cc (right): https://chromiumcodereview.appspot.com/10051011/diff/1/runtime/vm/code_generator_ia32.cc#newcode1338 runtime/vm/code_generator_ia32.cc:1338: } shouldn't there be an else with __PushObject(negate_result ? ...

8 years, 8 months ago (2012-04-11 17:25:08 UTC) #2

srdjan

LGTM as well On 2012/04/11 17:25:08, srdjan wrote: > https://chromiumcodereview.appspot.com/10051011/diff/1/runtime/vm/code_generator_ia32.cc > File runtime/vm/code_generator_ia32.cc (right): > ...

8 years, 8 months ago (2012-04-11 17:25:25 UTC) #3

regis

8 years, 8 months ago (2012-04-11 17:42:12 UTC) #4

Thanks!

https://chromiumcodereview.appspot.com/10051011/diff/1/runtime/vm/code_genera...
File runtime/vm/code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/10051011/diff/1/runtime/vm/code_genera...
runtime/vm/code_generator_ia32.cc:1338: }
On 2012/04/11 17:25:08, srdjan wrote:
> shouldn't there be an else with __PushObject(negate_result ? bool_true :
> bool_false) ?

Yes, indeed. I wanted to handle the malformed type case, and forgot. Done here
and in both 64-bit versions.

https://chromiumcodereview.appspot.com/10051011/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://chromiumcodereview.appspot.com/10051011/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_x64.cc:505: }
On 2012/04/11 17:25:08, srdjan wrote:
> ditto (missing an else)

Done.

Expand Messages | Collapse Messages