Issue 10050035: isolate: fix how we get the current script now that frog automatically wraps the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10050035: isolate: fix how we get the current script now that frog automatically wraps the (Closed)

Created:
8 years, 8 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 8 months ago

Reviewers:
eub, kasperl

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

isolate: fix how we get the current script now that frog automatically wraps the app to run on DOMContentLoaded. Committed: https://code.google.com/p/dart/source/detail?r=6959

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -31 lines)			Patch
M	lib/compiler/implementation/emitter.dart	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/isolate/frog/isolateimpl.dart	View		2 chunks	+3 lines, -31 lines	0 comments	Download
M	lib/isolate/frog/natives.js	View		2 chunks	+22 lines, -0 lines	0 comments	Download
A	tests/isolate/src/APIv2_computeThisScriptBrowserTest.dart	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Siggi Cherem (dart-lang)

This is basically how the code was when it was implemented in dartc. Now that ...

8 years, 8 months ago (2012-04-12 00:46:51 UTC) #1

Siggi Cherem (dart-lang)

Thanks Kasper, added a test that basically appends a script tag. I verified that this ...

8 years, 8 months ago (2012-04-12 17:56:53 UTC) #3

Siggi Cherem (dart-lang)

PTAL - I added a small change so that I don't break dart2js

8 years, 8 months ago (2012-04-12 18:12:12 UTC) #4

LGTM.