Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10050034: Do not require type class to be finalized when performing a type test. (Closed)

Created:
8 years, 8 months ago by regis
Modified:
8 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not require type class to be finalized when performing a type test. However, make sure that the interfaces are resolved (issue 2523). A later change will cleanup interface resolution code. Committed: https://code.google.com/p/dart/source/detail?r=6446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M runtime/vm/class_finalizer.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
8 years, 8 months ago (2012-04-11 23:58:06 UTC) #1
srdjan
8 years, 8 months ago (2012-04-12 00:00:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698