Issue 10050010: Avoid some unnecessary variables for phis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10050010: Avoid some unnecessary variables for phis. (Closed)

Created:
8 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid some unnecessary variables for phis. Detects some cases where the value of a phi is only used as input to another phi, and avoids creating an intermediate variable. Committed: https://code.google.com/p/dart/source/detail?r=6407

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -5 lines)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View		6 chunks	+22 lines, -5 lines	2 comments	Download
	M	lib/compiler/implementation/ssa/codegen_helpers.dart	View		1 chunk	+66 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/10050010/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10050010/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode646 lib/compiler/implementation/ssa/codegen.dart:646: // assingment. assignment

8 years, 8 months ago (2012-04-11 11:44:39 UTC) #2

Lasse Reichstein Nielsen

8 years, 8 months ago (2012-04-11 11:55:26 UTC) #3

https://chromiumcodereview.appspot.com/10050010/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10050010/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/codegen.dart:646: // assingment.
On 2012/04/11 11:44:39, floitsch wrote:
> assignment

Done.

Expand Messages | Collapse Messages