Issue 10041020: Fix bugs in cascade implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10041020: Fix bugs in cascade implementation. (Closed)

Created:
8 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 8 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bugs in cascade implementation. Some token.next got lost at some point. And tests weren't running. Committed: https://code.google.com/p/dart/source/detail?r=6672

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	frog/tests/leg_only/leg_only.status	View		1 chunk	+1 line, -1 line	2 comments	Download
	M	lib/compiler/implementation/scanner/parser.dart	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://chromiumcodereview.appspot.com/10041020/diff/1/frog/tests/leg_only/leg_only.status File frog/tests/leg_only/leg_only.status (right): https://chromiumcodereview.appspot.com/10041020/diff/1/frog/tests/leg_only/leg_only.status#newcode20 frog/tests/leg_only/leg_only.status:20: *: Fail, Pass # TODO(ahe): Triage these tests. Was ...

8 years, 8 months ago (2012-04-18 08:10:59 UTC) #1

ahe

8 years, 8 months ago (2012-04-18 08:35:35 UTC) #2

LGTM!

https://chromiumcodereview.appspot.com/10041020/diff/1/frog/tests/leg_only/le...
File frog/tests/leg_only/leg_only.status (right):

https://chromiumcodereview.appspot.com/10041020/diff/1/frog/tests/leg_only/le...
frog/tests/leg_only/leg_only.status:20: *: Fail, Pass # TODO(ahe): Triage these
tests.
On 2012/04/18 08:11:00, Lasse Reichstein Nielsen wrote:
> Was it intended to stop testing leg_only tests in leg?

No. This must be a typo.

Expand Messages | Collapse Messages