Issue 10035056: Fix a number of editor errors and warnings in io tests

Issue 10035056: Fix a number of editor errors and warnings in io tests (Closed)

Created:
8 years, 8 months ago by Søren Gjesse

Modified:
8 years, 8 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a number of editor errors and warnings in io tests R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6731

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -54 lines)			Patch
M	runtime/bin/file.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/standalone/src/io/ChunkedStreamTest.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/src/io/FileTest.dart	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	tests/standalone/src/io/HttpServerSocketTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/src/io/ListInputStreamTest.dart	View	12 chunks	+14 lines, -14 lines	0 comments	Download
M	tests/standalone/src/io/ListOutputStreamTest.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/standalone/src/io/ReadIntoConstList.dart	View	1 chunk	+2 lines, -0 lines	2 comments	Download
M	tests/standalone/src/io/Regress-1925.dart	View	3 chunks	+2 lines, -14 lines	0 comments	Download
M	tests/standalone/src/io/SocketExceptionTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/src/io/StringStreamTest.dart	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/standalone/src/io/TestingServer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM, thanks! Editor FTW! http://codereview.chromium.org/10035056/diff/1/tests/standalone/src/io/ReadIntoConstList.dart File tests/standalone/src/io/ReadIntoConstList.dart (right): http://codereview.chromium.org/10035056/diff/1/tests/standalone/src/io/ReadIntoConstList.dart#newcode8 tests/standalone/src/io/ReadIntoConstList.dart:8: #import("dart:io"); This test is not ...

8 years, 8 months ago (2012-04-19 09:08:35 UTC) #2

Søren Gjesse

8 years, 8 months ago (2012-04-19 09:17:26 UTC) #3

http://codereview.chromium.org/10035056/diff/1/tests/standalone/src/io/ReadIn...
File tests/standalone/src/io/ReadIntoConstList.dart (right):

http://codereview.chromium.org/10035056/diff/1/tests/standalone/src/io/ReadIn...
tests/standalone/src/io/ReadIntoConstList.dart:8: #import("dart:io");
On 2012/04/19 09:08:38, Mads Ager wrote:
> This test is not run. We need to rename it so it ends with Test.

Of cause, done.

Expand Messages | Collapse Messages