Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 10035032: Give a sourceElement to SSA instructions so that if they end up being 'define' in the codegen (ie n… (Closed)

Created:
8 years, 8 months ago by ngeoffray
Modified:
8 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, kasperl, karlklose, ahe, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Give a sourceElement to SSA instructions so that if they end up being 'define' in the codegen (ie needing a variable), they can use one related to the original source. Committed: https://code.google.com/p/dart/source/detail?r=6727

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M lib/compiler/implementation/ssa/builder.dart View 2 chunks +5 lines, -1 line 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
8 years, 8 months ago (2012-04-18 16:36:12 UTC) #1
floitsch
8 years, 8 months ago (2012-04-18 19:21:07 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698