Issue 10035006: Share intrinsification framework across architectures, started on instrinsification in the new comp…

Issue 10035006: Share intrinsification framework across architectures, started on instrinsification in the new comp… (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Share intrinsification framework across architectures, started on instrinsification in the new compiler x64. Committed: https://code.google.com/p/dart/source/detail?r=6661

Patch Set 4 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+982 lines, -198 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_patcher.h	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3	2 chunks	+1 line, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	3 chunks	+85 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1 2 3	3 chunks	+75 lines, -1 line	0 comments	Download
A	runtime/vm/intrinsifier.cc	View	1 2 3	1 chunk	+77 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1 2 3	2 chunks	+317 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 2 3	43 chunks	+101 lines, -187 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 2 3	2 chunks	+316 lines, -2 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10035006/diff/5004/runtime/vm/flow_graph_compiler_x64.cc File runtime/vm/flow_graph_compiler_x64.cc (right): https://chromiumcodereview.appspot.com/10035006/diff/5004/runtime/vm/flow_graph_compiler_x64.cc#newcode1540 runtime/vm/flow_graph_compiler_x64.cc:1540: // Sequence node has one return node, its ...

8 years, 8 months ago (2012-04-17 21:15:31 UTC) #2

srdjan

8 years, 8 months ago (2012-04-17 21:37:54 UTC) #3

https://chromiumcodereview.appspot.com/10035006/diff/5004/runtime/vm/flow_gra...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://chromiumcodereview.appspot.com/10035006/diff/5004/runtime/vm/flow_gra...
runtime/vm/flow_graph_compiler_x64.cc:1540: // Sequence node has one return
node, its input is oad field node.
On 2012/04/17 21:15:31, regis wrote:
> oad?

toad? road? aaaah .. load!

https://chromiumcodereview.appspot.com/10035006/diff/5004/runtime/vm/flow_gra...
runtime/vm/flow_graph_compiler_x64.cc:1605: __ nop(2);
On 2012/04/17 21:15:31, regis wrote:
> Why 2?

Patcheable entry needs certain code size.  nop(2) puts enough bytes. Added
comment

https://chromiumcodereview.appspot.com/10035006/diff/5004/runtime/vm/intrinsi...
File runtime/vm/intrinsifier.cc (right):

https://chromiumcodereview.appspot.com/10035006/diff/5004/runtime/vm/intrinsi...
runtime/vm/intrinsifier.cc:42: // special recognition of corelib private classes
On 2012/04/17 21:15:31, regis wrote:
> period missing

Done.

Expand Messages | Collapse Messages