Issue 10034019: Add missing calls to class finalizer in various tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10034019: Add missing calls to class finalizer in various tests. (Closed)

Created:
8 years, 8 months ago by regis

Modified:
8 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add missing calls to class finalizer in various tests. Make 'sentinel' and 'transition_sentinel' instances of class Null. Committed: https://code.google.com/p/dart/source/detail?r=6421

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -2 lines)			Patch
M	runtime/vm/code_descriptors_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/code_generator_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/compiler_test.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_entry_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	3 chunks	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/unit_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM If we determine that it is possible to use dynamic_class_ instead of null_class_ it ...

8 years, 8 months ago (2012-04-11 18:10:03 UTC) #2

regis

8 years, 8 months ago (2012-04-11 18:29:40 UTC) #3

On 2012/04/11 18:10:03, asiva wrote:
> LGTM
> 
> If we determine that it is possible to use dynamic_class_ instead of
null_class_
> it would be nice.

Thanks, Siva. So far, we do not have any instances of type Dynamic. We would
have to change the code at different places to support it, whereas we already
check for the NullClass in inlined code.

But I will keep this suggestion in mind.

Expand Messages | Collapse Messages