Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 10034001: Add support for importing using "package:" to the standalone VM. (Closed)

Created:
8 years, 8 months ago by Bob Nystrom
Modified:
8 years, 8 months ago
Reviewers:
nweiz, srdjan, siva, Ivan Posva
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

Add support for importing using "package:" to the standalone VM. Committed: https://code.google.com/p/dart/source/detail?r=6428

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't put entrypoint name in packages directory. #

Patch Set 3 : Respond to review. #

Total comments: 4

Patch Set 4 : Handle invalid package: URIs. #

Patch Set 5 : Error on domains with file: URIs too. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -7 lines) Patch
M runtime/bin/builtin.dart View 1 2 3 4 4 chunks +39 lines, -7 lines 3 comments Download
A tests/standalone/src/package/InvalidUriTest.dart View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A tests/standalone/src/package/PackageTest.dart View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A tests/standalone/src/package/packages/lib1.dart View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A tests/standalone/src/package/packages/lib2/lib2.dart View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A tests/standalone/src/package/packages/lib3/sub/lib3.dart View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A tests/standalone/src/package/packages/shared.dart View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Bob Nystrom
First pass at this. Let me know if there's anything you'd like me to do ...
8 years, 8 months ago (2012-04-09 23:32:42 UTC) #1
nweiz
lgtm https://chromiumcodereview.appspot.com/10034001/diff/1/tests/standalone/src/package/PackageTest.dart File tests/standalone/src/package/PackageTest.dart (right): https://chromiumcodereview.appspot.com/10034001/diff/1/tests/standalone/src/package/PackageTest.dart#newcode4 tests/standalone/src/package/PackageTest.dart:4: #library('package_test'); Nit: Empty line between license comment and ...
8 years, 8 months ago (2012-04-10 00:22:28 UTC) #2
Bob Nystrom
Changed to just use "packages" and not "entrypoint.packages" as the directory name as per our ...
8 years, 8 months ago (2012-04-10 00:57:47 UTC) #3
nweiz
lgtm
8 years, 8 months ago (2012-04-10 01:00:12 UTC) #4
Ivan Posva
LGTM -ip https://chromiumcodereview.appspot.com/10034001/diff/7005/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://chromiumcodereview.appspot.com/10034001/diff/7005/runtime/bin/builtin.dart#newcode105 runtime/bin/builtin.dart:105: var path = uri.path; Maybe we should ...
8 years, 8 months ago (2012-04-11 12:31:24 UTC) #5
Bob Nystrom
Thanks! Added some testing for incorrect URLs that have domains (and a negative test to ...
8 years, 8 months ago (2012-04-11 19:39:02 UTC) #6
srdjan
DBC https://chromiumcodereview.appspot.com/10034001/diff/11009/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://chromiumcodereview.appspot.com/10034001/diff/11009/runtime/bin/builtin.dart#newcode129 runtime/bin/builtin.dart:129: var path = _entrypoint.resolve('packages/${uri.path}').path; This probably does not ...
8 years, 8 months ago (2012-04-11 19:48:12 UTC) #7
Bob Nystrom
https://chromiumcodereview.appspot.com/10034001/diff/11009/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://chromiumcodereview.appspot.com/10034001/diff/11009/runtime/bin/builtin.dart#newcode129 runtime/bin/builtin.dart:129: var path = _entrypoint.resolve('packages/${uri.path}').path; On 2012/04/11 19:48:13, srdjan wrote: ...
8 years, 8 months ago (2012-04-11 20:28:04 UTC) #8
Ivan Posva
8 years, 8 months ago (2012-04-11 20:47:58 UTC) #9
https://chromiumcodereview.appspot.com/10034001/diff/11009/runtime/bin/builti...
File runtime/bin/builtin.dart (right):

https://chromiumcodereview.appspot.com/10034001/diff/11009/runtime/bin/builti...
runtime/bin/builtin.dart:129: var path =
_entrypoint.resolve('packages/${uri.path}').path;
On 2012/04/11 20:28:04, Bob Nystrom wrote:
> On 2012/04/11 19:48:13, srdjan wrote:
> > This probably does not work on windows....
> 
> I think that's OK, but I'm not sure. I don't see any of the existing code
> avoiding "/" on Windows here, so I assume that is handled further down.

As far as I can tell URIs contain forward slashes even on windows.

Powered by Google App Engine
This is Rietveld 408576698