Add support for the package: directive in Frog and dart2js.

Add support for the package: directive in Frog and dart2js.

Committed: https://code.google.com/p/dart/source/detail?r=6430

[Bob Nystrom, 2012-04-09 23:54:08]

Minor nits.

https://chromiumcodereview.appspot.com/10032015/diff/1/frog/reader.dart
File frog/reader.dart (right):

https://chromiumcodereview.appspot.com/10032015/diff/1/frog/reader.dart#newco...
frog/reader.dart:46: SourceFile readFile(String fullname) {
Should be "fullName".

https://chromiumcodereview.appspot.com/10032015/diff/1/lib/compiler/implement...
File lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10032015/diff/1/lib/compiler/implement...
lib/compiler/implementation/apiimpl.dart:71: translatePackageUri(Uri uri,
leg.ScriptTag node) =>
I <3 => too, but I think a regular {} body is better when it wraps to another
line.

[nweiz, 2012-04-10 00:16:31]

https://chromiumcodereview.appspot.com/10032015/diff/1/frog/reader.dart
File frog/reader.dart (right):

https://chromiumcodereview.appspot.com/10032015/diff/1/frog/reader.dart#newco...
frog/reader.dart:46: SourceFile readFile(String fullname) {
On 2012/04/09 23:54:08, Bob Nystrom wrote:
> Should be "fullName".

Done.

https://chromiumcodereview.appspot.com/10032015/diff/1/lib/compiler/implement...
File lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10032015/diff/1/lib/compiler/implement...
lib/compiler/implementation/apiimpl.dart:71: translatePackageUri(Uri uri,
leg.ScriptTag node) =>
On 2012/04/09 23:54:08, Bob Nystrom wrote:
> I <3 => too, but I think a regular {} body is better when it wraps to another
> line.

I think it's fine for a single-line body, even if that body's on the next line.
This pattern is pretty common in the existing codebase. We should have John
declare it one way or the other in the style guide.

[kasperl, 2012-04-11 14:10:56]

LGTM. I guess you'll land tests independently of this?

https://chromiumcodereview.appspot.com/10032015/diff/2002/lib/compiler/implem...
File lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10032015/diff/2002/lib/compiler/implem...
lib/compiler/implementation/apiimpl.dart:75: packageRoot =
uri.resolve('packages/');
Maybe reset packageRoot to null after running super.run? It really is a scoped
thing.

[nweiz, 2012-04-11 19:48:26]

I started writing tests for this, but I realized that there doesn't seem to be
any infrastructure in place for mocking out the filesystem to test import
statements. Are there any existing examples of this sort of test?

https://chromiumcodereview.appspot.com/10032015/diff/2002/lib/compiler/implem...
File lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10032015/diff/2002/lib/compiler/implem...
lib/compiler/implementation/apiimpl.dart:75: packageRoot =
uri.resolve('packages/');
On 2012/04/11 14:10:56, kasperl wrote:
> Maybe reset packageRoot to null after running super.run? It really is a scoped
> thing.

Done.

[Bob Nystrom, 2012-04-11 19:53:15]

On 2012/04/11 19:48:26, nweiz wrote:
> I started writing tests for this, but I realized that there doesn't seem to be
> any infrastructure in place for mocking out the filesystem to test import
> statements. Are there any existing examples of this sort of test?

You can see what I did for the standalone VM here:
https://chromiumcodereview.appspot.com/10034001/

- bob

[ahe, 2012-04-13 09:30:18]

In the future, I'd like to know about changes to this area (and it would be
really great if you CC compiler-dev@dartlang.org for changes to dart2js).

I'll be working on compiler API this Q, so we should chat about how the
packaging should be exposed in the API.

https://chromiumcodereview.appspot.com/10032015/diff/8001/lib/compiler/implem...
File lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10032015/diff/8001/lib/compiler/implem...
lib/compiler/implementation/apiimpl.dart:22: Uri packageRoot;
I think this should be initialized by the constructor.

https://chromiumcodereview.appspot.com/10032015/diff/8001/lib/compiler/implem...
lib/compiler/implementation/apiimpl.dart:83: packageRoot = null;
This "scoping" of packageRoot is weird to me, and I don't see how this will work
when the API is made fully asynchronous.