Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 10032009: Fix a crash in graoh builder where a throw node is added in an expression tree by the parser: allow… (Closed)

Created:
8 years, 8 months ago by srdjan
Modified:
8 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix a crash in graoh builder where a throw node is added in an expression tree by the parser: allow throws in expressions by not closing the fragment, instead return null as value. Committed: https://code.google.com/p/dart/source/detail?r=6340

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M runtime/vm/flow_graph_builder.h View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 chunks +15 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
8 years, 8 months ago (2012-04-09 20:38:11 UTC) #1
regis
8 years, 8 months ago (2012-04-09 20:57:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698