Issue 10027003: Fixes warnings and formatting issues in some dartc files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10027003: Fixes warnings and formatting issues in some dartc files (Closed)

Created:
8 years, 8 months ago by zundel

Modified:
8 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes warnings and formatting issues in some dartc files After these changes, I have no more warnings printed in Eclipse. Committed: https://code.google.com/p/dart/source/detail?r=6321

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -82 lines)			Patch
M	compiler/java/com/google/dart/compiler/SystemLibraryManager.java	View	13 chunks	+23 lines, -25 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/AbstractParser.java	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1 chunk	+0 lines, -9 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/testing/TestCompilerConfiguration.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/CompilerTestCase.java	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	11 chunks	+19 lines, -23 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	11 chunks	+17 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

https://chromiumcodereview.appspot.com/10027003/diff/1/compiler/java/com/google/dart/compiler/parser/DartParser.java File compiler/java/com/google/dart/compiler/parser/DartParser.java (left): https://chromiumcodereview.appspot.com/10027003/diff/1/compiler/java/com/google/dart/compiler/parser/DartParser.java#oldcode2957 compiler/java/com/google/dart/compiler/parser/DartParser.java:2957: private DartExpression parseAssignableSelector(DartExpression receiver) { I removed the reference ...

8 years, 8 months ago (2012-04-08 05:57:16 UTC) #1

LGTM

Expand Messages | Collapse Messages