Issue 10025031: Factored out common cases for type tests, used by instance of and assert assigneable. Using inlined…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10025031: Factored out common cases for type tests, used by instance of and assert assigneable. Using inlined… (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Factored out common cases for type tests, used by instance of and assert assigneable. Using inlined type test cache in assert assigneable. Committed: https://code.google.com/p/dart/source/detail?r=6764

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+339 lines, -306 lines)			Patch
M	runtime/vm/code_generator.cc	View	1	2 chunks	+40 lines, -5 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.h	View	1 2 3	2 chunks	+18 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 2 3	6 chunks	+281 lines, -299 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10025031/diff/7002/runtime/vm/code_generator_ia32.cc File runtime/vm/code_generator_ia32.cc (right): https://chromiumcodereview.appspot.com/10025031/diff/7002/runtime/vm/code_generator_ia32.cc#newcode1460 runtime/vm/code_generator_ia32.cc:1460: void CodeGenerator::TestClassAndJump(const Class& cls, Label* label) { Remove ...

8 years, 8 months ago (2012-04-19 20:10:40 UTC) #2

srdjan

8 years, 8 months ago (2012-04-19 20:12:49 UTC) #3

https://chromiumcodereview.appspot.com/10025031/diff/7002/runtime/vm/code_gen...
File runtime/vm/code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/10025031/diff/7002/runtime/vm/code_gen...
runtime/vm/code_generator_ia32.cc:1460: void
CodeGenerator::TestClassAndJump(const Class& cls, Label* label) {
On 2012/04/19 20:10:40, regis wrote:
> Remove this helper.

Done.

Expand Messages | Collapse Messages