Support passing the list of idl files to fremontcutbuilder.

Support passing the list of idl files to fremontcutbuilder.

Chrome gyp files define the list of all idl files used for bindings generation.
We need a way to pass this list to idl database builder so we are always up to date.

R=antonm@chromium.org,vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=6403

[Anton Muhin, 2012-04-09 13:26:29]

LGTM, but I expected you'll build a list from gyp

https://chromiumcodereview.appspot.com/10024016/diff/1/lib/dom/scripts/fremon...
File lib/dom/scripts/fremontcutbuilder.py (right):

https://chromiumcodereview.appspot.com/10024016/diff/1/lib/dom/scripts/fremon...
lib/dom/scripts/fremontcutbuilder.py:129: file_name = file_name.rstrip()
nit: just strip to be slightly safer?

[podivilov, 2012-04-09 14:05:59]

On 2012/04/09 13:26:29, antonmuhin wrote:
> LGTM, but I expected you'll build a list from gyp

See Dartium's counterpart http://codereview.chromium.org/10025022/

> 
>
https://chromiumcodereview.appspot.com/10024016/diff/1/lib/dom/scripts/fremon...
> File lib/dom/scripts/fremontcutbuilder.py (right):
> 
>
https://chromiumcodereview.appspot.com/10024016/diff/1/lib/dom/scripts/fremon...
> lib/dom/scripts/fremontcutbuilder.py:129: file_name = file_name.rstrip()
> nit: just strip to be slightly safer?

done.

[vsm, 2012-04-09 15:13:04]

LGTM

Just so I understand: you are doing this to avoid having to update the list of
IDL directories manually in fremontcutbuilder.py on a roll, correct?

My concern is making sure that we do update appropriately on the JS generation
side, but we can discuss later.

https://chromiumcodereview.appspot.com/10024016/diff/2002/lib/dom/scripts/fre...
File lib/dom/scripts/fremontcutbuilder.py (right):

https://chromiumcodereview.appspot.com/10024016/diff/2002/lib/dom/scripts/fre...
lib/dom/scripts/fremontcutbuilder.py:10: import tempfile
Nit: imports should be sorted.

[podivilov, 2012-04-09 15:26:26]

On 2012/04/09 15:13:04, vsm wrote:
> LGTM
> 
> Just so I understand: you are doing this to avoid having to update the list of
> IDL directories manually in fremontcutbuilder.py on a roll, correct?

Right.

> 
> My concern is making sure that we do update appropriately on the JS generation
> side, but we can discuss later.

We can introduce a gyp target to re-generate idl list when rolling pinned idls
forward. WDYT?

> 
>
https://chromiumcodereview.appspot.com/10024016/diff/2002/lib/dom/scripts/fre...
> File lib/dom/scripts/fremontcutbuilder.py (right):
> 
>
https://chromiumcodereview.appspot.com/10024016/diff/2002/lib/dom/scripts/fre...
> lib/dom/scripts/fremontcutbuilder.py:10: import tempfile
> Nit: imports should be sorted.
Done.

[vsm, 2012-04-10 18:47:52]

Still LGTM

On 2012/04/09 15:26:26, podivilov wrote:
> On 2012/04/09 15:13:04, vsm wrote:
> > LGTM
> > 
> > Just so I understand: you are doing this to avoid having to update the list
of
> > IDL directories manually in fremontcutbuilder.py on a roll, correct?
> 
> Right.
> 
> > 
> > My concern is making sure that we do update appropriately on the JS
generation
> > side, but we can discuss later.
> 
> We can introduce a gyp target to re-generate idl list when rolling pinned idls
> forward. WDYT?

Not sure what you have in mind (we can discuss outside this CL).  Would we add
this to all.deps gyp?

> 
> > 
> >
>
https://chromiumcodereview.appspot.com/10024016/diff/2002/lib/dom/scripts/fre...
> > File lib/dom/scripts/fremontcutbuilder.py (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10024016/diff/2002/lib/dom/scripts/fre...
> > lib/dom/scripts/fremontcutbuilder.py:10: import tempfile
> > Nit: imports should be sorted.
> Done.