Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 10021072: Remove the deprecated method invocation and field access apis from the (Closed)

Created:
8 years, 8 months ago by turnidge
Modified:
8 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove the deprecated method invocation and field access apis from the dart embbedding api. Use the new apis instead. Fixed a bug where field/function lookup was failing for imported libs. Added tests. Had to add a couple of lookup functions to Library. Fixed a bug in Dart_Invoke -- it wasn't handling a null receiver correctly. Committed: https://code.google.com/p/dart/source/detail?r=6769

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -1083 lines) Patch
M bin/main.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M include/dart_api.h View 1 2 chunks +0 lines, -82 lines 0 comments Download
M vm/custom_isolate_test.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download
M vm/dart_api_impl.cc View 1 8 chunks +9 lines, -307 lines 0 comments Download
M vm/dart_api_impl_test.cc View 1 49 chunks +243 lines, -571 lines 0 comments Download
M vm/debugger_api_impl_test.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M vm/exceptions_test.cc View 1 3 chunks +14 lines, -20 lines 0 comments Download
M vm/heap_test.cc View 1 2 chunks +10 lines, -16 lines 0 comments Download
M vm/isolate_test.cc View 1 1 chunk +9 lines, -13 lines 0 comments Download
M vm/object.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M vm/object.cc View 1 2 chunks +58 lines, -0 lines 0 comments Download
M vm/snapshot_test.cc View 1 7 chunks +15 lines, -45 lines 0 comments Download
M vm/stack_frame_test.cc View 1 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
turnidge
8 years, 8 months ago (2012-04-18 21:46:26 UTC) #1
Ivan Posva
8 years, 8 months ago (2012-04-19 18:21:28 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698