Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 10021025: Get rid of _idl_to_dart_type_conversions map. (Closed)

Created:
8 years, 8 months ago by podivilov
Modified:
8 years, 8 months ago
Reviewers:
sra, Anton Muhin, antonm, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get rid of _idl_to_dart_type_conversions map. This info is already contained in _idl_type_registry. R=antonm@chromium.org,sra@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6408

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -56 lines) Patch
M lib/dom/scripts/generator.py View 3 chunks +12 lines, -56 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
podivilov
8 years, 8 months ago (2012-04-09 14:18:04 UTC) #1
Anton Muhin
Neat, but I have one question https://chromiumcodereview.appspot.com/10021025/diff/1/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/10021025/diff/1/lib/dom/scripts/generator.py#newcode603 lib/dom/scripts/generator.py:603: 'DOMStringMap': PrimitiveIDLTypeInfo('DOMStringMap', dart_type='Map<String, ...
8 years, 8 months ago (2012-04-09 14:20:47 UTC) #2
podivilov
https://chromiumcodereview.appspot.com/10021025/diff/1/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/10021025/diff/1/lib/dom/scripts/generator.py#newcode603 lib/dom/scripts/generator.py:603: 'DOMStringMap': PrimitiveIDLTypeInfo('DOMStringMap', dart_type='Map<String, String>'), On 2012/04/09 14:20:47, antonmuhin wrote: ...
8 years, 8 months ago (2012-04-09 14:45:53 UTC) #3
Anton Muhin
LGTM, but, please, add a todo
8 years, 8 months ago (2012-04-09 14:51:38 UTC) #4
sra1
8 years, 8 months ago (2012-04-09 17:43:23 UTC) #5
lgtm.

Presumably this change by itself does not change the generated code.

Powered by Google App Engine
This is Rietveld 408576698