Issue 10020058: Fix a crash when optimizing instance field increment: if the increment operation gets interrupted b…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10020058: Fix a crash when optimizing instance field increment: if the increment operation gets interrupted b… (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a crash when optimizing instance field increment: if the increment operation gets interrupted because of an exception during increment the collected classes at getter and setter phases may differ (e.g., one class at getter, zero classes at setter). Committed: https://code.google.com/p/dart/source/detail?r=6443

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	runtime/vm/opt_code_generator_ia32.cc	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
	A	tests/language/src/ExceptionInIncrement.dart	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10020058/diff/2001/runtime/vm/opt_code_generator_ia32.cc File runtime/vm/opt_code_generator_ia32.cc (right): https://chromiumcodereview.appspot.com/10020058/diff/2001/runtime/vm/opt_code_generator_ia32.cc#newcode1448 runtime/vm/opt_code_generator_ia32.cc:1448: // Deoptimize if either this node has naver ...

8 years, 8 months ago (2012-04-11 22:13:04 UTC) #2

srdjan

8 years, 8 months ago (2012-04-11 22:16:37 UTC) #3

https://chromiumcodereview.appspot.com/10020058/diff/2001/runtime/vm/opt_code...
File runtime/vm/opt_code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/10020058/diff/2001/runtime/vm/opt_code...
runtime/vm/opt_code_generator_ia32.cc:1448: // Deoptimize if either this node
has naver been visited before or
On 2012/04/11 22:13:04, regis wrote:
> naver -> never

Done.

Expand Messages | Collapse Messages