Issue 10020008: Adds parser recovery to the class right brace and handles stray semicolons in a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10020008: Adds parser recovery to the class right brace and handles stray semicolons in a class (Closed)

Created:
8 years, 8 months ago by zundel

Modified:
8 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adds parser recovery to the class right brace and handles stray semicolons in a class I modified 'expectCloseBrace()' to not be so greedy of no opening brace was ever seen. Committed: https://code.google.com/p/dart/source/detail?r=6370

Patch Set 1 #

Total comments: 1

Patch Set 2 : # #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+304 lines, -35 lines)			Patch
	M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View		9 chunks	+47 lines, -35 lines	0 comments	Download
	M	compiler/javatests/com/google/dart/compiler/parser/ParserRecoveryTest.java	View	1	2 chunks	+257 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

https://chromiumcodereview.appspot.com/10020008/diff/1/compiler/java/com/google/dart/compiler/parser/DartParser.java File compiler/java/com/google/dart/compiler/parser/DartParser.java (right): https://chromiumcodereview.appspot.com/10020008/diff/1/compiler/java/com/google/dart/compiler/parser/DartParser.java#newcode668 compiler/java/com/google/dart/compiler/parser/DartParser.java:668: parseClassOrInterfaceBody(members); This is artificially split out just to use ...

8 years, 8 months ago (2012-04-08 13:18:30 UTC) #1

LGTM

Expand Messages | Collapse Messages