Issue 10019010: Adds more parser recovery to '#' directives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10019010: Adds more parser recovery to '#' directives (Closed)

Created:
8 years, 8 months ago by zundel

Modified:
8 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Adds more parser recovery to '#' directives Committed: https://code.google.com/p/dart/source/detail?r=6335

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -4 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	5 chunks	+30 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	4 chunks	+4 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/ParserRecoveryTest.java	View	2 chunks	+78 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

zundel

The parser just fell to pieces on a problem with a #import before this change.

8 years, 8 months ago (2012-04-08 09:26:48 UTC) #1

LGTM