Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 10014037: Fix win32 Socket test errors (Closed)

Created:
8 years, 8 months ago by siva
Modified:
8 years, 8 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix win32 Socket test errors SocketInfoTest and SocketPortTest are failing on windows. Committed: https://code.google.com/p/dart/source/detail?r=6390

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -15 lines) Patch
M runtime/bin/socket.h View 1 1 chunk +11 lines, -1 line 0 comments Download
M runtime/bin/socket.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
A runtime/bin/socket_linux.h View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/bin/socket_linux.cc View 2 chunks +0 lines, -4 lines 0 comments Download
A runtime/bin/socket_macos.h View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/bin/socket_macos.cc View 2 chunks +0 lines, -4 lines 0 comments Download
A runtime/bin/socket_win.h View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/bin/socket_win.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
siva
8 years, 8 months ago (2012-04-10 22:50:49 UTC) #1
hausner
8 years, 8 months ago (2012-04-10 23:18:43 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698