Remove EventListener attributes from Dart DOM API.

Remove EventListener attributes from Dart DOM API.

All idl interfaces that have EventListener attributes are EventTargets and implement
addEventListener/removeEventListener methods. We can safely drop this JavaScript legacy now.

The changes in dom and html libs are due to interfaces that are now treated as EventTargets
(the list of EventTargets in webkit-supplemental were not full).

R=sra@chromium.org,jacobr@google.com

Committed: https://code.google.com/p/dart/source/detail?r=6519

[Jacob, 2012-04-11 11:56:25]

lgtm for the systemhtml.py and generated dart:html changes.

[sra1, 2012-04-11 20:23:05]

Nice!

Do all the tests pass?
Do the samples build and run?

http://codereview.chromium.org/10014028/diff/1/lib/dom/scripts/dartgenerator.py
File lib/dom/scripts/dartgenerator.py (right):

http://codereview.chromium.org/10014028/diff/1/lib/dom/scripts/dartgenerator....
lib/dom/scripts/dartgenerator.py:337:
interface.parents.append(EventTargetParentInterface())
We should really append an IDLParentInterface, otherwise anything that does a
type test (e.g. printing) will not work properly.

Put a print in IDLParentInterface's constructor to see the shape of list you
need to pass in.

http://codereview.chromium.org/10014028/diff/1/lib/dom/scripts/dartgenerator....
lib/dom/scripts/dartgenerator.py:528: collected.append('EventTarget')
Why do you need this if you added a parent interface?

[podivilov, 2012-04-12 14:37:41]

The dart dom eng page says that "The Dart DOM API is tested as part of the
Dartium tests". Is it still true? Does it build and test frog version?

http://codereview.chromium.org/10014028/diff/1/lib/dom/scripts/dartgenerator.py
File lib/dom/scripts/dartgenerator.py (right):

http://codereview.chromium.org/10014028/diff/1/lib/dom/scripts/dartgenerator....
lib/dom/scripts/dartgenerator.py:337:
interface.parents.append(EventTargetParentInterface())
On 2012/04/11 20:23:05, sra1 wrote:
> We should really append an IDLParentInterface, otherwise anything that does a
> type test (e.g. printing) will not work properly.
> 
> Put a print in IDLParentInterface's constructor to see the shape of list you
> need to pass in.

Done.

http://codereview.chromium.org/10014028/diff/1/lib/dom/scripts/dartgenerator....
lib/dom/scripts/dartgenerator.py:528: collected.append('EventTarget')
On 2012/04/11 20:23:05, sra1 wrote:
> Why do you need this if you added a parent interface?

_ComputeInheritanceClosure is called too early, I moved EventTarget parent hack
here and removed this check.

[sra1, 2012-04-12 15:56:17]

lgtm if you move the fixing as described in the comment,

http://codereview.chromium.org/10014028/diff/5001/lib/dom/scripts/dartgenerat...
File lib/dom/scripts/dartgenerator.py (right):

http://codereview.chromium.org/10014028/diff/5001/lib/dom/scripts/dartgenerat...
lib/dom/scripts/dartgenerator.py:514: # Create fake EventTarget parent interface
for interfaces that have
I think it would be best to move this fixing to a separate function, e.g.
_FixEventTargets, called before _ComputeInheritanceClosure.
That way _ComputeInheritanceClosure is still an accurate name.