Issue 10014025: Anther attempt to fix the build after recent WebKit roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10014025: Anther attempt to fix the build after recent WebKit roll. (Closed)

Created:
8 years, 8 months ago by podivilov

Modified:
8 years, 8 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Anther attempt to fix the build after recent WebKit roll. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6372

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	client/tests/client/client.status	View		1 chunk	+1 line, -1 line	2 comments	Download
	M	client/tests/client/client-leg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

LGTM https://chromiumcodereview.appspot.com/10014025/diff/1/client/tests/client/client.status File client/tests/client/client.status (right): https://chromiumcodereview.appspot.com/10014025/diff/1/client/tests/client/client.status#newcode6 client/tests/client/client.status:6: dom/CallbacksTest: Pass, Fail # webkitRequestAnimationFrame now takes one ...

8 years, 8 months ago (2012-04-10 18:12:24 UTC) #2

podivilov

8 years, 8 months ago (2012-04-10 18:40:34 UTC) #3

https://chromiumcodereview.appspot.com/10014025/diff/1/client/tests/client/cl...
File client/tests/client/client.status (right):

https://chromiumcodereview.appspot.com/10014025/diff/1/client/tests/client/cl...
client/tests/client/client.status:6: dom/CallbacksTest: Pass, Fail #
webkitRequestAnimationFrame now takes one argument.
On 2012/04/10 18:12:24, antonmuhin wrote:
> why it flakes?  Usually it should either pass or fail.   But in any event, if
it
> fixes it, let it in and we'll adjust it as needed later.

It passes on dartium and some dart2js bots. On other platforms it fails. I'm not
sure how to express that in .status syntax.

Expand Messages | Collapse Messages