Issue 10014004: Preliminary selenium support for Dartium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10014004: Preliminary selenium support for Dartium (Closed)

Created:
8 years, 8 months ago by vsm

Modified:
8 years, 8 months ago

Reviewers:
Emily Fortuna, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Preliminary selenium support for Dartium Note, nothing is hooked up to get_drt.py --dartium yet. Future CLs will download it on demand in: - run_perf_tests.py - test.dart for webdriver tests Committed: https://code.google.com/p/dart/source/detail?r=6343

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added more comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -18 lines)			Patch
	M	tools/get_drt.py	View	1	5 chunks	+47 lines, -18 lines	0 comments	Download
	M	tools/testing/run_selenium.py	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm! https://chromiumcodereview.appspot.com/10014004/diff/1/tools/get_drt.py File tools/get_drt.py (right): https://chromiumcodereview.appspot.com/10014004/diff/1/tools/get_drt.py#newcode101 tools/get_drt.py:101: def get_latest(directory, version_file, latest_pattern, permanent_prefix): brief comments explaining ...

8 years, 8 months ago (2012-04-09 19:39:29 UTC) #2

Siggi Cherem (dart-lang)

8 years, 8 months ago (2012-04-09 20:58:17 UTC) #3

lgtm

https://chromiumcodereview.appspot.com/10014004/diff/1/tools/get_drt.py
File tools/get_drt.py (right):

https://chromiumcodereview.appspot.com/10014004/diff/1/tools/get_drt.py#newco...
tools/get_drt.py:177: get_latest(DRT_DIR, DRT_VERSION, DRT_LATEST_PATTERN,
DRT_PERMANENT_PREFIX)
do we need to always get the latest? Or could we update once a week? 

We could for instance add another argument/option '--latest' that forces to get
the latest.

Expand Messages | Collapse Messages