Rename Api::NewLocalHandle -> Api::NewHandle.

Rename Api::NewLocalHandle -> Api::NewHandle.

Api::NewHandle now takes a RawObject* intead of an Object&.
- This makes the code shorter and easier to read.
- This allows us to drop the DARTSCOPE from Dart_GetNativeArgument.
  (6% speedup on Benchmark_UseDartApi)
Committed: https://code.google.com/p/dart/source/detail?r=6283

[cshapiro, 2012-04-05 23:23:24]

lgtm - much cleaner!

https://chromiumcodereview.appspot.com/10014002/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10014002/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:388: } else if (obj.IsInstance()) {
When I have made a similar change, I was encourage to write my code like this...

  if (...) {
    return ...
  }
  if (...) {
    return ...
  }
  return ...

I think the desire was to lose the trailing else with a return and nothing
afterward.

[turnidge, 2012-04-06 16:50:48]

https://chromiumcodereview.appspot.com/10014002/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10014002/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:388: } else if (obj.IsInstance()) {
I prefer using the pattern you mention when there is asymmetry between the
cases.  Perhaps error bailouts followed by common case, or vice-versa, or maybe
fast-path(s) followed by slow-path.  In a case like this where I think of all
three clauses being parallel, I prefer to keep them parallel in the code.

On 2012/04/05 23:23:24, cshapiro wrote:
> When I have made a similar change, I was encourage to write my code like
this...
> 
>   if (...) {
>     return ...
>   }
>   if (...) {
>     return ...
>   }
>   return ...
> 
> I think the desire was to lose the trailing else with a return and nothing
> afterward.