Wire GrowableArray to use the internal VM object.

Wire GrowableArray to use the internal VM object.

This also fixes issue (5526318 : Make access to GrowableArray objects through the dart api more efficient)
Committed: https://code.google.com/p/dart/source/detail?r=6341

[srdjan, 2012-04-06 21:19:51]

LGTM

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array.cc
File lib/growable_array.cc (right):

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array....
lib/growable_array.cc:23: args.Add(&data);
Should this be data.Length() (as smi) ?

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array....
lib/growable_array.cc:34: GET_NATIVE_ARGUMENT(GrowableObjectArray, array,
arguments->At(0));
0 should be accessed via CheckedHandle, as it is the receiver.

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array....
lib/growable_array.cc:47: GET_NATIVE_ARGUMENT(GrowableObjectArray, array,
arguments->At(0));
ditto and elsewhere

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array....
File lib/growable_array.dart (right):

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array....
lib/growable_array.dart:48: throw new IllegalArgumentException("invalid length
specified");
Add $length to message?

https://chromiumcodereview.appspot.com/10012042/diff/4006/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10012042/diff/4006/vm/object.cc#newcod...
vm/object.cc:8577: intptr_t new_capacity = (Capacity() == 0) ? 4 : Capacity() *
2;
Capacity * 2 may be to-harsh. Adding one element to a 256k array creates a 512k
array... any plans there?

[siva, 2012-04-09 20:57:24]

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array.cc
File lib/growable_array.cc (right):

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array....
lib/growable_array.cc:23: args.Add(&data);
On 2012/04/06 21:19:51, srdjan wrote:
> Should this be data.Length() (as smi) ?

Done.

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array....
lib/growable_array.cc:34: GET_NATIVE_ARGUMENT(GrowableObjectArray, array,
arguments->At(0));
On 2012/04/06 21:19:51, srdjan wrote:
> 0 should be accessed via CheckedHandle, as it is the receiver.

Done.

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array....
lib/growable_array.cc:47: GET_NATIVE_ARGUMENT(GrowableObjectArray, array,
arguments->At(0));
On 2012/04/06 21:19:51, srdjan wrote:
> ditto and elsewhere

Done.

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array....
File lib/growable_array.dart (right):

https://chromiumcodereview.appspot.com/10012042/diff/4006/lib/growable_array....
lib/growable_array.dart:48: throw new IllegalArgumentException("invalid length
specified");
On 2012/04/06 21:19:51, srdjan wrote:
> Add $length to message?

Done.

https://chromiumcodereview.appspot.com/10012042/diff/4006/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10012042/diff/4006/vm/object.cc#newcod...
vm/object.cc:8577: intptr_t new_capacity = (Capacity() == 0) ? 4 : Capacity() *
2;
I have opened a Bug to track this and figure out how we should increment the
capacity
(Issue 2500). Added a TODO here.

On 2012/04/06 21:19:51, srdjan wrote:
> Capacity * 2 may be to-harsh. Adding one element to a 256k array creates a
512k
> array... any plans there?

[Ivan Posva, 2012-04-12 14:52:26]

https://chromiumcodereview.appspot.com/10012042/diff/14001/lib/growable_array...
File lib/growable_array.dart (right):

https://chromiumcodereview.appspot.com/10012042/diff/14001/lib/growable_array...
lib/growable_array.dart:112: void set data(ObjectArray<T> array) native
"GrowableObjectArray_setData";
Shouldn't this be a private method? As far as I understand this slams the native
backing store directly.