Issue 10010007: Report missing #source after 'unitAboutToCompile'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10010007: Report missing #source after 'unitAboutToCompile' (Closed)

Created:
8 years, 8 months ago by scheglov

Modified:
8 years, 8 months ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report missing #source after 'unitAboutToCompile' R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6220

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -48 lines)			Patch
M	compiler/java/com/google/dart/compiler/DartCompiler.java	View	3 chunks	+15 lines, -9 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View	7 chunks	+59 lines, -21 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/MemoryLibrarySource.java	View	5 chunks	+10 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

8 years, 8 months ago (2012-04-05 14:55:09 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10010007/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
(right):

https://chromiumcodereview.appspot.com/10010007/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java:64:
/*private long appSourceLastModified = 0;
you can delete this now, right?

Expand Messages | Collapse Messages